Migrate IVF-Flat from RAFT#94
Merged
rapids-bot[bot] merged 40 commits intorapidsai:branch-24.06from May 16, 2024
Merged
Conversation
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
Signed-off-by: Mickael Ide <[email protected]>
divyegala
added
feature request
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
cjnolet
reviewed
Apr 26, 2024
cjnolet
requested changes
Apr 26, 2024
lowener
reviewed
May 13, 2024
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
cjnolet
reviewed
May 14, 2024
cjnolet
reviewed
May 14, 2024
Member
Author
|
/ok to test |
cjnolet
reviewed
May 14, 2024
cjnolet
reviewed
May 14, 2024
cjnolet
reviewed
May 14, 2024
cjnolet
reviewed
May 14, 2024
cjnolet
reviewed
May 14, 2024
Member
Author
|
/ok to test |
cjnolet
reviewed
May 14, 2024
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
cjnolet
reviewed
May 16, 2024
| namespace codepacker { | ||
| namespace detail { | ||
| template <typename T, typename IdxT> | ||
| void pack( |
Member
There was a problem hiding this comment.
Please move these into "ivf_flat_helpers.cuh" with the other templates so they can be used more broadly than just within this source file if needed.
Member
Author
There was a problem hiding this comment.
These methods already are in the public API. Should I still move them?
Member
There was a problem hiding this comment.
Yes, please move the templates to ivf_flat_helpers.cuh. I understand they are being instantiated here, but templates are far more useful (and reusable) in header files.
cjnolet
approved these changes
May 16, 2024
Member
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
I went ahead and implemented the last change in my PR downstream .
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.