[Java] Replace the C wrapper layer with the Panama API-based Java implementation by narangvivek10 · Pull Request #916 · rapidsai/cuvs

narangvivek10 · 2025-05-21T03:43:03Z

The code changes in this pull request intends to replace the C wrapper layer with the Panama API-based Java implementation.

copy-pr-bot · 2025-05-21T03:43:07Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

…xParams

chatman · 2025-05-27T20:04:48Z

@cjnolet This is not ready to merge yet, but can you please trigger a CI run once? I want to make sure that the tests are able to find the correct .so file in the CI environment after my latest commit.

cjnolet · 2025-05-27T20:12:08Z

/ok to test 442a67e

chatman · 2025-05-27T21:02:05Z

Thanks Corey. There's a failure, perhaps related to jextract?

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (compile-java-22) on project cuvs-java: Compilation failure: Compilation failure: 
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/BruteForceIndexImpl.java:[43,1] cannot find symbol
Error:    symbol:   static cudaMemcpy
Error:    location: class com.nvidia.cuvs.internal.panama.PanamaFFMAPI_1
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/common/Util.java:[26,1] cannot find symbol
Error:    symbol:   static cudaMemGetInfo
Error:    location: class com.nvidia.cuvs.internal.panama.PanamaFFMAPI_1
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/CagraIndexImpl.java:[43,1] cannot find symbol
Error:    symbol:   static cudaMemcpy
Error:    location: class com.nvidia.cuvs.internal.panama.PanamaFFMAPI_1
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/common/Util.java:[155,23] cannot find symbol
Error:    symbol:   method cudaMemGetInfo(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment)
Error:    location: class com.nvidia.cuvs.internal.common.Util
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/BruteForceIndexImpl.java:[165,21] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.BruteForceIndexImpl
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/BruteForceIndexImpl.java:[256,21] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.BruteForceIndexImpl
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/BruteForceIndexImpl.java:[282,23] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.BruteForceIndexImpl
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/BruteForceIndexImpl.java:[301,21] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.BruteForceIndexImpl
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/BruteForceIndexImpl.java:[303,21] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.BruteForceIndexImpl
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/CagraIndexImpl.java:[253,21] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.CagraIndexImpl
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/CagraIndexImpl.java:[280,21] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.CagraIndexImpl
Error:  /__w/cuvs/cuvs/java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/CagraIndexImpl.java:[282,21] cannot find symbol
Error:    symbol:   method cudaMemcpy(java.lang.foreign.MemorySegment,java.lang.foreign.MemorySegment,long,int)
Error:    location: class com.nvidia.cuvs.internal.CagraIndexImpl
Error:  -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

FYI @narangvivek10

Seems like cudaMemcpy isn't found by jextract. In my local build, the following file contains the cudaMemcpy signatures:

/usr/local/cuda-12.6/targets/x86_64-linux/include/cuda_runtime_api.h

Wondering why it wasn't found on the CI machine?

Co-authored-by: Vivek Narang <[email protected]>

mythrocks · 2025-06-02T21:04:41Z

/ok to test ff0c7a3

mythrocks · 2025-06-02T21:05:35Z

Given that 25.06 has sailed, we should retarget this to the 25.08 branch.

narangvivek10 · 2025-06-04T02:15:01Z

Remaining conflicts fixed with 410de12

@cjnolet please trigger CI run when you can. Thanks!

mythrocks · 2025-06-04T05:34:42Z

/ok to test 39f92d7

chatman · 2025-06-04T07:01:28Z

The java tests passed, but some Python tests (unrelated to this change) failed. Should we merge this now?

cjnolet · 2025-06-04T13:26:19Z

@chatman as mentioned before, we cannot merge PRs until all checks pass.

cjnolet · 2025-06-04T13:27:20Z

@viclafargue it looks like there are a couple mg test failures. Are you able to look into this?

cjnolet · 2025-06-04T17:35:00Z

/ok to test 2b56f59

chatman · 2025-06-04T20:07:52Z

In the latest run, the following test failed with a segfault:

[       OK ] AnnMGTest/AnnMGTestF_float.AnnMG/4 (633 ms)
[ RUN      ] AnnMGTest/AnnMGTestF_float.AnnMG/5
CMake Error at run_gpu_test.cmake:35 (execute_process):
  execute_process failed command indexes:

    1: "Abnormal exit with child return code: Segmentation fault"

@cjnolet In case this is a flaky test, can we re-run this?

cjnolet · 2025-06-05T00:01:20Z

/ok to test b104f19

cjnolet · 2025-06-05T00:02:50Z

/merge

…lementation (rapidsai#916) The code changes in this pull request intends to replace the C wrapper layer with the Panama API-based Java implementation. Authors: - Vivek Narang (https://github.com/narangvivek10) - Ishan Chattopadhyaya (https://github.com/chatman) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: rapidsai#916

narangvivek10 added 6 commits May 15, 2025 23:53

initial work

acae395

fix for cagra search

3116819

bruteforce implementation

29362e5

hnsw implementation

4ffec00

gpuInfo implementation

f6bb090

CAGRA index dims and size implementation

f150914

github-actions Bot added the cpp label May 21, 2025

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

228a02f

punAhuja mentioned this pull request May 21, 2025

[Java] Adding support for prefiltering in CAGRA #870

Merged

cjnolet assigned narangvivek10 May 21, 2025

cjnolet added this to Unstructured Data Processing May 21, 2025

cjnolet moved this to In Progress in Unstructured Data Processing May 21, 2025

cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 22, 2025

remove panama class and additional refactoring

d8c8769

github-actions Bot removed the cpp label May 22, 2025

narangvivek10 and others added 6 commits May 22, 2025 13:22

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

184f12b

update CagraBuildAndSearchIT - remove getIndexSize call

d7ce786

additional refactoring changes

1dabaf8

API update - move CagraCompressionParams from CagraIndex to CagraInde…

ac9f98d

…xParams

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

de65604

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

9481325

narangvivek10 changed the title ~~[Java API] Replace the C wrapper layer with the Panama API-based Java implementation~~ [Java] Replace the C wrapper layer with the Panama API-based Java implementation May 26, 2025

narangvivek10 and others added 3 commits May 27, 2025 14:32

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

cd8b859

Find the libcuvs_c.so during runtime, using LD_LIBRARY_PATH

66dca00

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

442a67e

chatman added a commit to SearchScale/cuvs that referenced this pull request Jun 1, 2025

Remove Intermediate C layer (rapidsai#916)

499581b

chatman added a commit to SearchScale/cuvs that referenced this pull request Jun 1, 2025

Remove Intermediate C layer (rapidsai#916)

94aa66d

chatman added a commit to SearchScale/cuvs that referenced this pull request Jun 2, 2025

Remove Intermediate C layer (rapidsai#916)

5fb4a36

Co-authored-by: Vivek Narang <[email protected]>

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

ff0c7a3

mythrocks reviewed Jun 2, 2025

View reviewed changes

Comment thread java/cuvs-java/pom.xml

Merge branch 'branch-25.06' into vivek/replace-c-layer-with-panama-impl

d69d12a

mythrocks changed the base branch from branch-25.06 to branch-25.08 June 3, 2025 22:28

Merge branch 'branch-25.08' into vivek/replace-c-layer-with-panama-impl

410de12

style-check fixes

39f92d7

Merge branch 'branch-25.08' into vivek/replace-c-layer-with-panama-impl

2b56f59

KyleFromNVIDIA requested changes Jun 4, 2025

View reviewed changes

Comment thread java/internal/CMakeLists.txt Outdated

Comment thread java/build.sh Outdated

chatman mentioned this pull request Jun 4, 2025

Add C-API method to fetch cuVS version from Java. #935

Merged

review fixes

b104f19

KyleFromNVIDIA approved these changes Jun 5, 2025

View reviewed changes

cjnolet removed the request for review from msarahan June 5, 2025 01:57

rapids-bot Bot merged commit b18e199 into rapidsai:branch-25.08 Jun 5, 2025
53 checks passed

github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Jun 5, 2025

ldematte mentioned this pull request Jun 11, 2025

cuvs-java: CagraBuildAndSearchIT crashes with pure virtual method called terminate called without an active exception #764

Closed

Conversation

narangvivek10 commented May 21, 2025

Uh oh!

copy-pr-bot Bot commented May 21, 2025

Uh oh!

chatman commented May 27, 2025

Uh oh!

cjnolet commented May 27, 2025

Uh oh!

chatman commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mythrocks commented Jun 2, 2025

Uh oh!

mythrocks commented Jun 2, 2025

Uh oh!

Uh oh!

narangvivek10 commented Jun 4, 2025

Uh oh!

mythrocks commented Jun 4, 2025

Uh oh!

chatman commented Jun 4, 2025

Uh oh!

cjnolet commented Jun 4, 2025

Uh oh!

cjnolet commented Jun 4, 2025

Uh oh!

cjnolet commented Jun 4, 2025

Uh oh!

chatman commented Jun 4, 2025

Uh oh!

Uh oh!

Uh oh!

cjnolet commented Jun 5, 2025

Uh oh!

cjnolet commented Jun 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chatman commented May 27, 2025 •

edited

Loading