Change snmg index to use updated multi gpu resource API#869
Conversation
Signed-off-by: jinsolp <[email protected]>
…/jinsolp/cuvs into mg-change-for-multi-gpu-resource
| GIT_REPOSITORY https://github.com/jinsolp/raft.git | ||
| GIT_TAG multi-gpu-resource |
There was a problem hiding this comment.
This needs to be reverted
Signed-off-by: jinsolp <[email protected]>
viclafargue
left a comment
There was a problem hiding this comment.
Thanks @jinsolp, LGTM apart from the benchmark files. Could you switch the raft::device_resources_snmg to raft::device_resources_snmg_nccl?
|
@viclafargue Thanks for pointing out Victor, I also had to change function calls in |
devices_resources_snmg_nccl
…/jinsolp/cuvs into mg-change-for-multi-gpu-resource
|
@jinsolp don't forget to revert the change in |
…/jinsolp/cuvs into mg-change-for-multi-gpu-resource
devices_resources_snmg_nccl|
Hi Jinsol, did you have a chance to run the ann_bench with the new changes? |
|
@achirkin I only verified the gtests, let me try running the ANN BENCH thanks for pointing out : ) |
|
Should be fixed now |
The existing `nccl_clique.hpp` assumes usage of nccl when using multiple gpus. However, this is not always the case, and we want to generalize the use of multi-gpu resource by decoupling it from nccl usage. This PR is mostly a refactoring of existing code to lazy-load nccl for `device_resources_snmg` resource. ### Dependencies **The merge of this PR will break cuVS**. Thankfully (and hopefully) it will not break anything else since `nccl_clique.hpp` was recently introduced and is only used for snmg neighbors index related code. [This PR in cuVS ](rapidsai/cuvs#869) makes corresponding changes (changing include header file name etc...) to make this code work with cuVS. There are no functional differences. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Victor Lafargue (https://github.com/viclafargue) - Artem M. Chirkin (https://github.com/achirkin) - Divye Gala (https://github.com/divyegala) URL: #2647
…/jinsolp/cuvs into mg-change-for-multi-gpu-resource
|
/merge |
Description
These changes are dependent on this breaking PR in raft.
This PR itself doesn't introduce any new features, but makes changes to the existing code to work with the breaking changes in the PR in raft.