Skip to content

IVF-PQ tests: fix segfault when accessing empty lists #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Apr 24, 2025
Merged

IVF-PQ tests: fix segfault when accessing empty lists #838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c400a58
Check if list is empty in tests
achirkin Apr 23, 2025
a34a078
Merge branch 'branch-25.06' into fix-tests-ivf-pq-list-empty-segfault
cjnolet Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp/tests/neighbors/ann_ivf_pq.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,11 @@ class ivf_pq_test : public ::testing::TestWithParam<ivf_pq_inputs> {
// the original data cannot be reconstructed since the dataset was normalized
if (index.metric() == cuvs::distance::DistanceType::CosineExpanded) { return; }
auto& rec_list = index.lists()[label];
auto dim = index.dim();
n_take = std::min<uint32_t>(n_take, rec_list->size.load());
n_skip = std::min<uint32_t>(n_skip, rec_list->size.load() - n_take);
// If the data is unbalanced the list might be empty, which is actually nullptr
if (!rec_list) { return; }
auto dim = index.dim();
n_take = std::min<uint32_t>(n_take, rec_list->size.load());
n_skip = std::min<uint32_t>(n_skip, rec_list->size.load() - n_take);

if (n_take == 0) { return; }

Expand Down