Skip to content

[FEA] Build Single Linkage API#820

Merged
rapids-bot[bot] merged 60 commits intorapidsai:branch-25.08from
tarang-jain:build-linkage
Jun 30, 2025
Merged

[FEA] Build Single Linkage API#820
rapids-bot[bot] merged 60 commits intorapidsai:branch-25.08from
tarang-jain:build-linkage

Conversation

@tarang-jain
Copy link
Copy Markdown
Contributor

@tarang-jain tarang-jain commented Apr 12, 2025 •
edited
Loading

  • Expose functions for building the dendrogram on the mutual reachability graph

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 12, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tarang-jain tarang-jain self-assigned this Apr 12, 2025
@github-actions github-actions Bot added the cpp label Apr 12, 2025
@tarang-jain tarang-jain added feature request New feature or request non-breaking Introduces a non-breaking change labels Apr 17, 2025
@tarang-jain tarang-jain marked this pull request as ready for review April 18, 2025 03:15
@tarang-jain tarang-jain requested a review from a team as a code owner April 18, 2025 03:15
@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Apr 18, 2025

/ok to test

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 18, 2025

/ok to test

@tarang-jain, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Apr 18, 2025

/ok to test 2738db7

@divyegala divyegala mentioned this pull request Apr 18, 2025
Closed
5 tasks
@tarang-jain tarang-jain mentioned this pull request Apr 18, 2025
Merged
@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Apr 18, 2025

Notes:
These functions have been migrated from HDBSCAN runner in cuML and exposed as a new public API, that is not tested directly here. Instead the full usage is tested end-to-end in HDBSCAN inside cuML. To veify correctness, the cuML PR (rapidsai/cuml#6560), that uses this, currently fetches cuVS from the branch of this cuVS PR and the CI status on that PR can be checked. Once this PR is merged, I will revert the CMake changes to find the correct cuvs version in rapidsai/cuml#6560

jinsolp
jinsolp reviewed Apr 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR Tarang! LGTM, just a few small suggestions : )

Comment thread cpp/include/cuvs/cluster/agglomerative.hpp Outdated
Comment thread cpp/src/cluster/detail/single_linkage.cuh Outdated
Comment thread cpp/src/cluster/single_linkage.cuh Outdated
tarang-jain and others added 3 commits April 18, 2025 18:51
rm template
a58e72d
@tarang-jain @jinsolp
Update cpp/src/cluster/detail/single_linkage.cuh
291ef55 
Co-authored-by: Jinsol Park <jinsolp@nvidia.com>
@tarang-jain @jinsolp
Update cpp/src/cluster/single_linkage.cuh
a35ad32 
Co-authored-by: Jinsol Park <jinsolp@nvidia.com>
@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Apr 19, 2025

/ok to test

@tarang-jain tarang-jain mentioned this pull request Jun 5, 2025
Closed
@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Jun 5, 2025

/ok to test 1dd9039

@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Jun 5, 2025

/ok to test 5426b35

@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Jun 5, 2025

/ok to test 3b0737d

@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Jun 8, 2025

/ok to test 6afb096

divyegala
divyegala reviewed Jun 9, 2025
View reviewed changes
Comment thread cpp/src/cluster/detail/single_linkage.cuh
Comment thread cpp/src/cluster/detail/single_linkage.cuh
@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Jun 10, 2025

/ok to test b86b6bd

@tarang-jain
Copy link
Copy Markdown
Contributor Author

tarang-jain commented Jun 30, 2025

/ok to test 63e65a4

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jun 30, 2025

/merge

@rapids-bot rapids-bot Bot merged commit fb969cc into rapidsai:branch-25.08 Jun 30, 2025
53 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Jun 30, 2025
rapids-bot Bot pushed a commit to rapidsai/cuml that referenced this pull request Jul 10, 2025
@tarang-jain
[FEA] HDBSCAN to Migrate to cuVS cluster prims from raft::cluster (#6560
c7d59fa 
)

Depends on rapidsai/cuvs#820.

Authors:
  - Tarang Jain (https://github.com/tarang-jain)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Victor Lafargue (https://github.com/viclafargue)

URL: #6560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjnolet cjnolet cjnolet left review comments

@divyegala divyegala divyegala approved these changes

@jinsolp jinsolp jinsolp approved these changes

Assignees

@tarang-jain tarang-jain

Labels

cpp feature request New feature or request non-breaking Introduces a non-breaking change

Projects

Unstructured Data Processing
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tarang-jain @divyegala @cjnolet @jinsolp