add function to build specific gpu-arches [REVIEW] #766
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.04from Apr 1, 2025
Merged
Conversation
nvrohanv
changed the title
bkarsin
added
non-breaking
bkarsin
reviewed
Mar 20, 2025
| if hasArg --allgpuarch && [[ -n $(echo $ARGS | { grep -E "\-\-gpu\-arch" || true; } ) ]]; then | ||
| echo "Error: Cannot specify both --gpu-arch and --allgpuarch" | ||
| echo "Use either:" | ||
| echo " --gpu-arch=\"80-real;90-real\" (for specific architectures)" |
Contributor
There was a problem hiding this comment.
Can we add a link or reference about different architecture numbers and real vs. virtual? Some users may not know where to find this info.
Contributor
Author
There was a problem hiding this comment.
Added in instructions and a link in the help message for the main command. the example build.sh seems more barebone and doesn't have a help message so didn't add anything there, but presumably someone would've used the main build.sh first.
Contributor
|
/ok to test |
bkarsin
approved these changes
Mar 26, 2025
cjnolet
approved these changes
Mar 26, 2025
Member
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
Very useful. Great to see users can't specify both allgpuarch and gpuarchs. Thanks!
Contributor
|
/ok to test |
Contributor
|
/ok to test |
gforsyth
approved these changes
Apr 1, 2025
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in functions to the root level build.sh so that you can specify which GPU architectures you want to build for. Currently the only options were to build for the current system or for all systems. It also adds this option into
examples/build.shin addition to fixing bugs with the clean command.A
--gpu-archoption is added that is meant to be used to provide which architectures to build for e.g../build.sh bench-ann --gpu-arch="80-real;90-real"