Skip to content

[Feat] Expose search with bitset C API for Brute Force#717

Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.04from
rhdong:rhdong/bf-bitset-c
Mar 6, 2025
Merged

[Feat] Expose search with bitset C API for Brute Force#717
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.04from
rhdong:rhdong/bf-bitset-c

Conversation

@rhdong
Copy link
Copy Markdown
Member

@rhdong rhdong commented Feb 24, 2025

No description provided.

@rhdong rhdong requested a review from a team as a code owner February 24, 2025 16:47
@github-actions github-actions Bot added the cpp label Feb 24, 2025
@rhdong rhdong added feature request New feature or request non-breaking Introduces a non-breaking change labels Feb 24, 2025
@rhdong rhdong requested a review from benfred February 25, 2025 00:00
Copy link
Copy Markdown
Contributor

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks great - thanks for submitting!

Can we get this exposed to python as well? This might only involve updating the documentation and adding a unittest (and since cagra/ivf-flat share the same test

@pytest.mark.parametrize("sparsity", [0.5, 0.7, 1.0])
def test_filtered_ivf_flat(sparsity):
run_filtered_search_test(ivf_flat, sparsity)
adding the unittest will hopefully be pretty easy)

@rhdong rhdong requested a review from a team as a code owner February 28, 2025 01:09
@rhdong
Copy link
Copy Markdown
Member Author

rhdong commented Feb 28, 2025

This PR looks great - thanks for submitting!

Can we get this exposed to python as well? This might only involve updating the documentation and adding a unittest (and since cagra/ivf-flat share the same test

@pytest.mark.parametrize("sparsity", [0.5, 0.7, 1.0])
def test_filtered_ivf_flat(sparsity):
run_filtered_search_test(ivf_flat, sparsity)

adding the unittest will hopefully be pretty easy)

Hi @benfred, thank you for your time. After studying our code, I believe there should be no need to change the Python API, and I just updated the doc work for filter.from_bitset. cc: @cjnolet

Copy link
Copy Markdown
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rhdong
Copy link
Copy Markdown
Member Author

rhdong commented Feb 28, 2025

Amazing, the failure log shows the code being tested is old.. had to rerun..

@rhdong
Copy link
Copy Markdown
Member Author

rhdong commented Feb 28, 2025

/ok to test

@benfred
Copy link
Copy Markdown
Contributor

benfred commented Mar 6, 2025

/merge

@rapids-bot rapids-bot Bot merged commit e8d5b9b into rapidsai:branch-25.04 Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp feature request New feature or request non-breaking Introduces a non-breaking change Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants