Skip to content

Replace cub::TransformInputIterator with thrust::transform_iterator#707

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.04from
miscco:replace_cub_transform_iterator
Feb 20, 2025
Merged

Replace cub::TransformInputIterator with thrust::transform_iterator#707
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.04from
miscco:replace_cub_transform_iterator

Conversation

@miscco
Copy link
Copy Markdown
Contributor

@miscco miscco commented Feb 18, 2025

The former is deprecated and will be removed in a future release

The former is deprecated and will be removed in a future release
@miscco miscco requested a review from a team as a code owner February 18, 2025 08:33
@github-actions github-actions Bot added the cpp label Feb 18, 2025
@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 18, 2025
@miscco
Copy link
Copy Markdown
Contributor Author

miscco commented Feb 19, 2025

@cjnolet I ran the tests locally without any issue. That said I am not 100% sure whether I have the exact same environment

@miscco
Copy link
Copy Markdown
Contributor Author

miscco commented Feb 20, 2025

@cjnolet it seems to be passing with the latest fix. Can you by change rerun the failed nightly run once nightly is green again?

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Feb 20, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 2f999ba into rapidsai:branch-25.04 Feb 20, 2025
@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Feb 20, 2025

/merge

@miscco miscco deleted the replace_cub_transform_iterator branch February 23, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants