expose cuvsResources_t to python#58
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.04from Mar 21, 2024
Merged
Conversation
The current python code was creating a cuvsResources_t to pass to the CAGRA apis on the build/search code. This both ignored the passed in `resources` object, and also leaked memory since it wasn't calling cuvsResourcesDestroy. Fix by exposing the cuvsResources_t object to python.
benfred
added
improvement
divyegala
approved these changes
Mar 21, 2024
Contributor
Author
|
/merge |
benfred
added a commit
to benfred/cuvs
that referenced
this pull request
Mar 21, 2024
Also use the python resources object from rapidsai#58
benfred
added a commit
to benfred/cuvs
that referenced
this pull request
Apr 5, 2024
The current python code was creating a cuvsResources_t to pass to the CAGRA apis on the build/search code. This both ignored the passed in `resources` object, and also leaked memory since it wasn't calling cuvsResourcesDestroy. Fix by exposing the cuvsResources_t object to python. Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current python code was creating a cuvsResources_t to pass to the CAGRA apis on the build/search code. This both ignored the passed in
resourcesobject, and also leaked memory since it wasn't calling cuvsResourcesDestroy.Fix by exposing the cuvsResources_t object to python.