Run cuvs-bench pytests and end-to-end tests in CI #574
Merged
rapids-bot[bot] merged 30 commits intorapidsai:branch-25.02from Feb 7, 2025
Merged
Run cuvs-bench pytests and end-to-end tests in CI #574rapids-bot[bot] merged 30 commits intorapidsai:branch-25.02from
rapids-bot[bot] merged 30 commits intorapidsai:branch-25.02from
Conversation
… e2e tests CI scripts
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cjnolet
added
improvement
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
dantegd
commented
Feb 4, 2025
Member
Author
|
/ok to test |
cjnolet
reviewed
Feb 4, 2025
| search: | ||
| itopk: [32, 64, 128, 256, 512] | ||
| search_width: [1, 2, 4, 8, 16, 32, 64] | ||
| test: |
cjnolet
reviewed
Feb 4, 2025
| - librmm==25.2.*,>=0.0.0a0 | ||
| - matplotlib | ||
| - matplotlib-base | ||
| - nccl>=2.19 |
Member
There was a problem hiding this comment.
Does Scikit-learn also need to be added here?
cjnolet
reviewed
Feb 4, 2025
cjnolet
reviewed
Feb 5, 2025
| download(args.dataset, args.normalize, args.dataset_path) | ||
| f.attrs["distance"] = metric | ||
|
|
||
| convert_hdf5_to_fbin(full_path, normalize=True) |
Member
There was a problem hiding this comment.
I wonder- should we add debug prints before download and convert_hdf5_to_fbin as well, just in case they fail?
jameslamb
approved these changes
Feb 5, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
I left some minor, but they're minor so giving you a ci-codeowners / packaging-codeowners approval so you have what you need to merge. Please do consider them.
cjnolet
approved these changes
Feb 6, 2025
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR does the following: