Remove unused get_*.cmake files.#57
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.04from Mar 19, 2024
Merged
Conversation
bdice
added
improvement
bdice
changed the title
Contributor
Author
|
We can retarget to 24.06 if desired. I think this PR should be low-risk, since there were no references to the deleted files and CI is passing. |
lowener
approved these changes
Mar 19, 2024
Contributor
Author
|
/merge |
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Mar 20, 2024
This PR removes some unused `get_*.cmake` files. I know cuVS may need to add some of these back as functionality is migrated from RAFT. As that happens, I would like to copy them again from the latest versions in RAFT. Specifically, files like `get_thrust.cmake` are outdated (we are moving to `rapids_cpm_cccl` and `rapids_cpm_thrust` is deprecated) so this will reduce the maintenance burden for CMake / build system developers in the interim period. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Micka (https://github.com/lowener) URL: rapidsai#57
benfred
pushed a commit
to benfred/cuvs
that referenced
this pull request
Apr 5, 2024
This PR removes some unused `get_*.cmake` files. I know cuVS may need to add some of these back as functionality is migrated from RAFT. As that happens, I would like to copy them again from the latest versions in RAFT. Specifically, files like `get_thrust.cmake` are outdated (we are moving to `rapids_cpm_cccl` and `rapids_cpm_thrust` is deprecated) so this will reduce the maintenance burden for CMake / build system developers in the interim period. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Micka (https://github.com/lowener) URL: rapidsai#57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some unused
get_*.cmakefiles. I know cuVS may need to add some of these back as functionality is migrated from RAFT. As that happens, I would like to copy them again from the latest versions in RAFT.Specifically, files like
get_thrust.cmakeare outdated (we are moving torapids_cpm_ccclandrapids_cpm_thrustis deprecated) so this will reduce the maintenance burden for CMake / build system developers in the interim period.