Update for raft logger changes#540
Merged
rapids-bot[bot] merged 11 commits intorapidsai:branch-25.02from Dec 31, 2024
Merged
Conversation
vyasr
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
I'll be on vacation next week and this PR has downstream consequences so I've marked it as "DO NOT MERGE" until I get back, but I would love to get it reviewed in advance so that I can safely merge when I'm ready. |
vyasr
commented
Dec 19, 2024
Contributor
Author
|
The devcontainer failures are expected here until we merge the raft PR. |
bdice
approved these changes
Dec 19, 2024
cjnolet
approved these changes
Dec 20, 2024
vyasr
added
breaking
Contributor
Author
|
/merge |
rapids-bot Bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Dec 31, 2024
This PR updates cuml to use raft's updated logger implementation using [rapids-logger](https://github.com/rapidsai/rapids-logger). This PR requires rapidsai/cuvs#540 (cuml requires both raft and cuvs updates). Contributes to rapidsai/build-planning#104 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) URL: #6187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates cuvs to use raft's updated logger implementation using rapids-logger. It is a breaking change because it changes the kmeans
base_paramsverbosity type from an int to araft::level_enum.This PR requires rapidsai/raft#2530.
Contributes to rapidsai/build-planning#104