Change brute_force api to match ivf*/cagra#536
Merged
Conversation
This changes the brute_force knn api to match that of ivf-* and cagra , by adding a search_params and index_params structure to the relevant calls. This allows us to use the dynamic batching code on brute_force knn, as well as provide a more standardized API for our users.
benfred
added
improvement
cjnolet
approved these changes
Jan 7, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the brute_force knn api to match that of ivf-* and cagra , by adding a search_params and index_params structure to the relevant calls.
This allows us to use the dynamic batching code on brute_force knn, as well as provide a more standardized API for our users.