Skip to content

Skip IVF-PQ packing test for lists with not enough data#512

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.12from
achirkin:fix-ivf-pq-check-packing-gtest
Dec 5, 2024
Merged

Skip IVF-PQ packing test for lists with not enough data#512
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.12from
achirkin:fix-ivf-pq-check-packing-gtest

Conversation

@achirkin
Copy link
Copy Markdown
Contributor

@achirkin achirkin commented Dec 4, 2024

Skip some checks involving hard-coded offsets into the data when the number of records in the checked PQ list is smaller than needed.

@achirkin achirkin added the bug Something isn't working label Dec 4, 2024
@achirkin achirkin requested a review from a team as a code owner December 4, 2024 16:13
@github-actions github-actions Bot added the cpp label Dec 4, 2024
@achirkin achirkin added the non-breaking Introduces a non-breaking change label Dec 4, 2024
Copy link
Copy Markdown
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for fixing this, LGTM!

@achirkin
Copy link
Copy Markdown
Contributor Author

achirkin commented Dec 5, 2024

/merge

@rapids-bot rapids-bot Bot merged commit c9b3862 into rapidsai:branch-24.12 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cpp non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants