use different wheel-size thresholds based on CUDA version#469
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.12from Nov 15, 2024
jameslamb:wheel-validation-pt2
Merged
use different wheel-size thresholds based on CUDA version#469rapids-bot[bot] merged 1 commit intorapidsai:branch-24.12from jameslamb:wheel-validation-pt2
rapids-bot[bot] merged 1 commit intorapidsai:branch-24.12from
jameslamb:wheel-validation-pt2
Conversation
jameslamb
added
improvement
This was referenced Nov 14, 2024
jameslamb
changed the title
msarahan
approved these changes
Nov 15, 2024
Member
Author
|
Thanks @msarahan ! |
Member
Author
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this pull request
Nov 27, 2024
Following #2498, we can apply this feedback from #2490: #2490 (comment) These changes are inspired by rapidsai/cuvs#469. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #2509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuvs-cu11wheels are significantly larger thancuvs-cu12wheels, because (among other reasons) they are not able to dynamically link to CUDA math library wheels.In #464, I proposed a size limit for CI checks of "max CUDA 11 wheel size + a buffer".
This PR proposes using different thresholds based on CUDA major version, following these discussions: