Fix index overflow in edge cases of CAGRA graph optimize#435
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.12from Nov 1, 2024
Merged
Conversation
achirkin
added
bug
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force
input_graph_degree,output_graph_degree, andgraph_sizevariables touint64_t.Before the PR, they've been
uint32_t, and the product of them could overflow. This would lead tocudaMemsetAsyncnot filling in a large fraction of the graph.It's not known whether this bug has surfaced for anyone until now, but it's better to be safe than sorry.
The change shouldn't have any impact on performance.