Skip to content

Add ci run_ scripts needed for build infra#434

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.12from
robertmaynard:fea/add_ci_run_test_scripts
Oct 30, 2024
Merged

Add ci run_ scripts needed for build infra#434
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.12from
robertmaynard:fea/add_ci_run_test_scripts

Conversation

@robertmaynard
Copy link
Copy Markdown
Contributor

These run_* scripts are needed by the build infra team and bring the cuvs project in line with the rest of RAPIDS

@robertmaynard robertmaynard requested a review from a team as a code owner October 29, 2024 15:32
@github-actions github-actions Bot added the ci label Oct 29, 2024
Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal of this PR is consistency with the rest of RAPIDS, I think the pytests script should be named run_cuvs_pytests.sh.

As most other projects do:

Giving you a ci-codeowners approval so you don't have to request another review, but I do think you should make that change.

@jameslamb jameslamb removed the request for review from msarahan October 29, 2024 17:18
@robertmaynard
Copy link
Copy Markdown
Contributor Author

If the goal of this PR is consistency with the rest of RAPIDS, I think the pytests script should be named run_cuvs_pytests.sh.

As most other projects do:

Giving you a ci-codeowners approval so you don't have to request another review, but I do think you should make that change.

Happy to do so, I was copying kvikio ( https://github.com/rapidsai/kvikio/blob/branch-24.12/ci/run_pytests.sh ) which also only has a single python package. But we can rename now in expection that cuvs will have multiple packages

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 30, 2024
@jameslamb
Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot Bot merged commit b422cbe into rapidsai:branch-24.12 Oct 30, 2024
@robertmaynard robertmaynard deleted the fea/add_ci_run_test_scripts branch October 30, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants