Add ci run_ scripts needed for build infra#434
Add ci run_ scripts needed for build infra#434rapids-bot[bot] merged 2 commits intorapidsai:branch-24.12from
Conversation
jameslamb
left a comment
There was a problem hiding this comment.
If the goal of this PR is consistency with the rest of RAPIDS, I think the pytests script should be named run_cuvs_pytests.sh.
As most other projects do:
- raft example: https://github.com/rapidsai/raft/tree/branch-24.12/ci
- cudf example: https://github.com/rapidsai/cudf/tree/branch-24.12/ci
- cuml example: https://github.com/rapidsai/cuml/tree/branch-24.12/ci
Giving you a ci-codeowners approval so you don't have to request another review, but I do think you should make that change.
Happy to do so, I was copying kvikio ( https://github.com/rapidsai/kvikio/blob/branch-24.12/ci/run_pytests.sh ) which also only has a single python package. But we can rename now in expection that cuvs will have multiple packages |
|
/merge |
These
run_*scripts are needed by the build infra team and bring the cuvs project in line with the rest of RAPIDS