Skip to content

fix style checks on Python 3.12#328

Merged
AyodeAwe merged 1 commit intorapidsai:branch-24.10from
jameslamb:fix/style-checks
Sep 17, 2024
Merged

fix style checks on Python 3.12#328
AyodeAwe merged 1 commit intorapidsai:branch-24.10from
jameslamb:fix/style-checks

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented Sep 17, 2024

After merging rapidsai/ci-imgs#188, style checks here started breaking like this:

python/cuvs/cuvs/test/test_doctests.py:103:24: E231 missing whitespace after ':'
python/cuvs/cuvs/test/test_doctests.py:124:27: E231 missing whitespace after ':'

(build link)

Looks like both of those are false positives (we really do intend to not have a space after the : on those lines). This proposes ignoring them with #noqa comments.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Sep 17, 2024
@jameslamb jameslamb requested a review from a team as a code owner September 17, 2024 16:22
@jameslamb
Copy link
Copy Markdown
Member Author

check-style is passing here: https://github.com/rapidsai/cuvs/actions/runs/10907091447/job/30269909264?pr=328

I'll ask for an admin merge.

@jameslamb jameslamb requested a review from bdice September 17, 2024 16:30
@AyodeAwe AyodeAwe merged commit e58b1d0 into rapidsai:branch-24.10 Sep 17, 2024
@jameslamb jameslamb deleted the fix/style-checks branch September 17, 2024 16:39
bdice added a commit to bdice/cuvs that referenced this pull request Sep 17, 2024
@jameslamb
Copy link
Copy Markdown
Member Author

For those finding this from search.... the better fix was just to upgrade flake8 to 7.1.1. A bug in earlier versions led to these false positives.

That was done here: #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants