fix style checks on Python 3.12#328
Merged
AyodeAwe merged 1 commit intorapidsai:branch-24.10from Sep 17, 2024
jameslamb:fix/style-checks
Merged
fix style checks on Python 3.12#328AyodeAwe merged 1 commit intorapidsai:branch-24.10from jameslamb:fix/style-checks
AyodeAwe merged 1 commit intorapidsai:branch-24.10from
jameslamb:fix/style-checks
Conversation
Member
Author
|
I'll ask for an admin merge. |
bdice
added a commit
to bdice/cuvs
that referenced
this pull request
Sep 17, 2024
This reverts commit e58b1d0.
Member
Author
|
For those finding this from search.... the better fix was just to upgrade That was done here: #327 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging rapidsai/ci-imgs#188, style checks here started breaking like this:
(build link)
Looks like both of those are false positives (we really do intend to not have a space after the
:on those lines). This proposes ignoring them with#noqacomments.