Skip to content

Fixed link to build docs and corrected ivf_flat_example #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Jul 30, 2024
Merged

Fixed link to build docs and corrected ivf_flat_example #255

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b6380f
Fixed link to build docs and corrected ivf_flat_example note for hand…
mmccarty Jul 26, 2024
1c805f4
Merge branch 'branch-24.10' into readme-notebook-quick-fixes
cjnolet Jul 29, 2024
3178e84
Linking directly to rendered docs for build structions
mmccarty Jul 29, 2024
42d1076
Merge branch 'branch-24.10' into readme-notebook-quick-fixes
cjnolet Jul 29, 2024
a7517b7
Merge branch 'branch-24.10' into readme-notebook-quick-fixes
cjnolet Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ If installing a version that has not yet been released, the `rapidsai` channel c
mamba install -c conda-forge -c nvidia -c rapidsai-nightly cuvs=24.10
```

Please see the [Build and Install Guide](docs/source/build.md) for more information on installing cuVS and building from source.
Please see the [Build and Install Guide](docs/source/build.rst) for more information on installing cuVS and building from source.
Comment thread
mmccarty marked this conversation as resolved.
Outdated

## Getting Started

Expand Down
12 changes: 6 additions & 6 deletions notebooks/ivf_flat_example.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@
"search_params = ivf_flat.SearchParams(n_probes=30)\n",
"\n",
"# Search 10 nearest neighbors.\n",
"distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, handle=handle)\n",
"distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, resources=handle)\n",
" \n",
"# cuVS calls are asynchronous (when handle arg is provided), we need to sync before accessing the results.\n",
"handle.sync()\n",
Expand Down Expand Up @@ -302,7 +302,7 @@
" index,\n",
" cp.asarray(queries),\n",
" k=10,\n",
" handle=handle,\n",
" resources=handle,\n",
" )\n",
" handle.sync()\n",
" \n",
Expand Down Expand Up @@ -382,7 +382,7 @@
" add_data_on_build=True\n",
" )\n",
"\n",
"index = ivf_flat.build(build_params, dataset, handle=handle)"
"index = ivf_flat.build(build_params, dataset, resources=handle)"
]
},
{
Expand All @@ -406,7 +406,7 @@
"search_params = ivf_flat.SearchParams(n_probes=10)\n",
"\n",
"# Search 10 nearest neighbors.\n",
"distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, handle=handle)\n",
"distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, resources=handle)\n",
" \n",
"handle.sync()\n",
"distances, neighbors = cp.asnumpy(distances), cp.asnumpy(indices)"
Expand Down Expand Up @@ -445,7 +445,7 @@
" kmeans_trainset_fraction=0.1, \n",
" kmeans_n_iters=20 \n",
" ) \n",
"index = ivf_flat.build(build_params, dataset, handle=handle)"
"index = ivf_flat.build(build_params, dataset, resources=handle)"
]
},
{
Expand All @@ -465,7 +465,7 @@
"source": [
"search_params = ivf_flat.SearchParams(n_probes=10)\n",
"\n",
"distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, handle=handle)\n",
"distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, resources=handle)\n",
" \n",
"handle.sync()\n",
"distances, neighbors = cp.asnumpy(distances), cp.asnumpy(indices)\n",
Expand Down