CAGRA bench: use device-side refinement when the data is on device#228
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.08from Jul 17, 2024
Merged
Conversation
tfeher
approved these changes
Jul 17, 2024
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Artem for the fix, LGTM!
tfeher
added
bug
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CAGRA build benchmark always assuming the dataset is on host.
Before the fix, this would result in the refinement step being performed on host even if the data is on device; this would lead to a segfault.