CAGRA: reduce argument count in select_and_run() kernel wrappers#227
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-24.08from Jul 23, 2024
Merged
Conversation
Merged
tfeher
reviewed
Jul 22, 2024
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Artem for the PR! The changes so far look good, but don't we need to change search_*_cta_kernel-ext.cuh files too?
Contributor
Author
|
Thanks for noticing this, Tamas! I've updated the |
tfeher
approved these changes
Jul 23, 2024
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks Artem for updating the PR and filing the issue. LGTM.
tfeher
added
improvement
Contributor
|
/merge |
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Jul 31, 2024
…idsai#227) A small change that reduces the number of arguments in one of the wrapper layers in the detail namespace of CAGRA. The goal is twofold: 1) Simplify the overly long signature of `selet_and_run` (which has many instances) 2) Give access to all search parameters for future upgrades of the search kernel This is to simplify the integration (and review) of the persistent kernel (rapidsai#215). No performance or functional changes expected. Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#227
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change that reduces the number of arguments in one of the wrapper layers in the detail namespace of CAGRA. The goal is twofold:
selet_and_run(which has many instances)This is to simplify the integration (and review) of the persistent kernel (#215).
No performance or functional changes expected.