Add col-major support for brute force knn#217
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.08from Jul 17, 2024
Merged
Add col-major support for brute force knn#217rapids-bot[bot] merged 4 commits intorapidsai:branch-24.08from
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.08from
Conversation
benfred
added
improvement
tarang-jain
approved these changes
Jul 12, 2024
Contributor
tarang-jain
left a comment
tarang-jain
left a comment
There was a problem hiding this comment.
Thanks for this PR. Looks good to me.
cjnolet
approved these changes
Jul 17, 2024
Member
|
I'm going to merge this now just to unblock @tarang-jain so we can finalize the faiss+cubs updates. We should follow up with the tile-by-tile solution to improve memory usage. |
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.