Skip to content

Faiss suppress warning 611#1879

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:faiss-suppress-warning-611
Mar 5, 2026
Merged

Faiss suppress warning 611#1879
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:faiss-suppress-warning-611

Conversation

@aamijar
Copy link
Copy Markdown
Member

@aamijar aamijar commented Mar 4, 2026 •
edited
Loading

Mitigation to #1881

@aamijar aamijar requested a review from a team as a code owner March 4, 2026 22:50
@aamijar aamijar self-assigned this Mar 4, 2026
@aamijar aamijar added bug Something isn't working faiss non-breaking Introduces a non-breaking change labels Mar 4, 2026
@aamijar aamijar moved this to In Progress in Unstructured Data Processing Mar 4, 2026
@jinsolp
Copy link
Copy Markdown
Contributor

jinsolp commented Mar 5, 2026

Thanks @aamijar ! Can we add an issue so we can revert this change whenever Faiss is fixed?

@aamijar aamijar mentioned this pull request Mar 5, 2026
Open
@aamijar
Copy link
Copy Markdown
Member Author

aamijar commented Mar 5, 2026

Thanks @aamijar ! Can we add an issue so we can revert this change whenever Faiss is fixed?

Added the issue in the PR description

@jinsolp
Copy link
Copy Markdown
Contributor

jinsolp commented Mar 5, 2026

ccing @tarang-jain to make sure this is a good change regarding Faiss

tarang-jain
tarang-jain reviewed Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tarang-jain tarang-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. It is a bit unsettling to manually suppress warnings in our wrappers in this fashion. I wonder why this suddenly came up (not finding anything fishy in the recent commits to Faiss main). Do you have any idea what recently changed in Faiss?

@aamijar
Copy link
Copy Markdown
Member Author

aamijar commented Mar 5, 2026

Hi @tarang-jain, please see the linked issue for the details.

tarang-jain
tarang-jain approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tarang-jain tarang-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as a temporary fix, but this needs to be reverted and the Faiss version needs to be pinned (#1884)

@aamijar
Copy link
Copy Markdown
Member Author

aamijar commented Mar 5, 2026

/merge

@rapids-bot rapids-bot Bot merged commit efbfc41 into rapidsai:main Mar 5, 2026
226 of 230 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Mar 5, 2026
@aamijar aamijar mentioned this pull request Mar 5, 2026
Merged
rapids-bot Bot pushed a commit that referenced this pull request Mar 5, 2026
@aamijar
Pin faiss to 1.14.0 (#1885)
24e42cd 
Follow up to #1879. Resolves #1884

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Tarang Jain (https://github.com/tarang-jain)

URL: #1885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarang-jain tarang-jain tarang-jain approved these changes

Assignees

@aamijar aamijar

Labels

bug Something isn't working faiss non-breaking Introduces a non-breaking change

Projects

Unstructured Data Processing
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aamijar @jinsolp @tarang-jain