Fix setting CAGRA graph build algo to iterative search by default#1864
Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom Mar 4, 2026
Merged
Conversation
achirkin
added
bug
tarang-jain
reviewed
Mar 3, 2026
| @@ -291,16 +296,18 @@ void parse_build_param(const nlohmann::json& conf, cuvs::neighbors::cagra::index | |||
| nlohmann::json nn_descent_conf = collect_conf_with_prefix(conf, "nn_descent_"); | |||
| nlohmann::json ace_conf = collect_conf_with_prefix(conf, "ace_"); | |||
Contributor
There was a problem hiding this comment.
Should we also collect iterative search params here and then check for that collected conf below in the monostate if condition?
Contributor
There was a problem hiding this comment.
I think this will also require changes to collect_conf_with_prefix
Contributor
Author
There was a problem hiding this comment.
Thanks for noticing! No, the iterative search params are an empty data type - no parameters to collect
tarang-jain
approved these changes
Mar 3, 2026
Contributor
tarang-jain
left a comment
tarang-jain
left a comment
There was a problem hiding this comment.
LGTM except one suggestion which need not necessarily be addressed in this PR
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are no graph build parameters set up and no
graph_build_algoset explicitly in the CAGRA build params, ANN_BENCH defaults to iterative search, effectively bypassing the algorithm selection logic. This PR fixes that.Resolves #1849