refactor(limited api): add explicit wheel.py-api to pyproject.toml
#1852
Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom Feb 26, 2026
Merged
refactor(limited api): add explicit wheel.py-api to pyproject.toml
#1852rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
wheel.py-api to pyproject.toml
#1852rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
Conversation
gforsyth
added
non-breaking
jameslamb
approved these changes
Feb 25, 2026
Contributor
Author
|
/merge |
tfeher
pushed a commit
to Stardust-SJF/cuvs_rabitq
that referenced
this pull request
Mar 3, 2026
rapidsai#1852) As part of rapidsai/build-planning#42 I added support for building limited API wheels and conda packages. To enable a RAPIDS-wide bump of the lower-bound of the limited API version we use (currently `cp311`), the flags that set these options are passed in via environment variables. This leads us to an issue where local developer builds, either in devcontainers or otherwise, will build without the limited API, unless devs have set an (otherwise unnecessary) environment variable. So here, I set the `py-api` version explicitly, so that local builds will always produce limited API wheels and so better reflect what we build and test in CI. We retain the ability to bump all of RAPIDS to a different `cp3xx` value because the flag passed in by our scripts overrides the value set in the `pyproject.toml`. There may be short periods where the flags we are building with and the flags set in `pyproject.toml` differ, but that should happen infrequently at best. Authors: - Gil Forsyth (https://github.com/gforsyth) Approvers: - James Lamb (https://github.com/jameslamb) URL: rapidsai#1852
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of rapidsai/build-planning#42 I added support for building limited API wheels and conda packages.
To enable a RAPIDS-wide bump of the lower-bound of the limited API version we use (currently
cp311), the flags that set these options are passed in via environment variables.This leads us to an issue where local developer builds, either in devcontainers or otherwise, will build without the limited API, unless devs have set an (otherwise unnecessary) environment variable.
So here, I set the
py-apiversion explicitly, so that local builds will always produce limited API wheels and so better reflect what we build and test in CI.We retain the ability to bump all of RAPIDS to a different
cp3xxvalue because the flag passed in by our scripts overrides the value set in thepyproject.toml. There may be short periods where the flags we are building with and the flags set inpyproject.tomldiffer, but that should happen infrequently at best.