-
Notifications
You must be signed in to change notification settings - Fork 184
Set cudaFuncAttributeMaxDynamicSharedMemorySize with thread-safety
#1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
96af4dd
305cb55
4463666
677f6fe
5e9e410
f55cbd3
b394b19
f3efb37
8792c40
e55eb23
2a5a00f
b1b97cc
f50d4d4
c2b1c43
8d66233
1acb864
1d41373
f6cf7d3
9b13500
8d6fb1a
1cd8b2c
9ed3400
1955dce
3ba77d5
5a8771c
45dff11
8c107e1
a6f3071
d3f6ecd
088fcc8
856e695
eff47c8
b59b8c3
3581c01
80825ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
| #pragma once | ||
|
|
||
| #include <raft/util/cuda_rt_essentials.hpp> | ||
|
|
||
| #include <cstdint> | ||
| #include <mutex> | ||
|
|
||
| namespace cuvs::neighbors::detail { | ||
|
|
||
| /** | ||
| * @brief Optionally set the larger max dynamic shared memory size for the kernel. | ||
| * This is required because `cudaFuncSetAttribute` is not thread-safe. | ||
| * In the event of concurrent calls, we'd like to accommodate the largest requested size. | ||
| * @tparam KernelT The type of the kernel. | ||
| * @param smem_size The size of the dynamic shared memory to be set. | ||
| * @param kernel The kernel to be set. | ||
| */ | ||
| template <typename KernelT> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should work fine if the kernel type is different for each CUDA kernel instantiation. I am not familiar with this. |
||
| void optionally_set_larger_max_smem_size(uint32_t smem_size, KernelT& kernel) | ||
| { | ||
| static auto mutex = std::mutex{}; | ||
| static auto running_max_smem_size = uint32_t{0}; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would maybe make
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think that's necessary. Per the C++ standard, a function static's initialization is threadsafe. The updates are within the critical section. Forgive me if I've missed the point of concern. |
||
| if (smem_size > running_max_smem_size) { | ||
| auto guard = std::lock_guard<std::mutex>{mutex}; | ||
| if (smem_size > running_max_smem_size) { | ||
| running_max_smem_size = smem_size; | ||
| RAFT_CUDA_TRY(cudaFuncSetAttribute( | ||
| kernel, cudaFuncAttributeMaxDynamicSharedMemorySize, running_max_smem_size)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } // namespace cuvs::neighbors::detail | ||
|
mythrocks marked this conversation as resolved.
|
||
Uh oh!
There was an error while loading. Please reload this page.