Skip to content

Fix multi-GPU All Neighbors memory coherence issue on older platforms#1713

Merged
rapids-bot[bot] merged 5 commits intorapidsai:release/26.02from
viclafargue:fix-multi-gpu-all-neighbors-memory-coherence-issue
Jan 28, 2026
Merged

Fix multi-GPU All Neighbors memory coherence issue on older platforms#1713
rapids-bot[bot] merged 5 commits intorapidsai:release/26.02from
viclafargue:fix-multi-gpu-all-neighbors-memory-coherence-issue

Conversation

@viclafargue
Copy link
Copy Markdown
Contributor

@viclafargue viclafargue requested a review from jinsolp January 20, 2026 15:34
@viclafargue viclafargue requested a review from a team as a code owner January 20, 2026 15:34
@viclafargue viclafargue added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 20, 2026
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @viclafargue thanks for working on this!

Comment thread cpp/src/neighbors/all_neighbors/all_neighbors_batched.cuh Outdated
Comment thread cpp/src/neighbors/all_neighbors/all_neighbors_batched.cuh Outdated
Copy link
Copy Markdown
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just some minor suggestions alongside @jinsolp review

Comment thread cpp/src/neighbors/all_neighbors/all_neighbors_batched.cuh
Comment thread cpp/src/neighbors/all_neighbors/all_neighbors_batched.cuh
Comment thread cpp/src/neighbors/all_neighbors/all_neighbors_batched.cuh
Copy link
Copy Markdown
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI passing

Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@viclafargue viclafargue force-pushed the fix-multi-gpu-all-neighbors-memory-coherence-issue branch from 47ef3dc to 13d18df Compare January 26, 2026 17:44
@viclafargue viclafargue changed the base branch from main to release/26.02 January 26, 2026 17:45
@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 28, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 605c4e1 into rapidsai:release/26.02 Jan 28, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] test_umap_trustworthiness_on_batch_nnd test failure with multiple GPUs

4 participants