[Bug] Fix memory allocation test in CAGRA graph optimization#1675
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Jan 8, 2026
Merged
Conversation
cjnolet
approved these changes
Jan 8, 2026
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rel: #1619
The actual memory allocation is performed by
make_device_mdarray, so the corresponding memory allocation test should also be done using this function. However, the current code usesmake_device_matrixfor the test.This PR fixes this inconsistency.
In the same source file,
d_detour_countandd_num_no_detour_edgesare allocated viamake_device_mdarray, andd_input_graphis allocated throughdevice_matrix_view_from_host(defined incpp/src/neighbors/detail/cagra/utils.hpp), which internally callsmake_device_mdarray.