Skip to content

[Bug] Fix memory allocation test in CAGRA graph optimization#1675

Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
enp1s0:fix-cagra-graph-opt-memory-allocation
Jan 8, 2026
Merged

[Bug] Fix memory allocation test in CAGRA graph optimization#1675
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
enp1s0:fix-cagra-graph-opt-memory-allocation

Conversation

@enp1s0
Copy link
Copy Markdown
Member

@enp1s0 enp1s0 commented Jan 7, 2026

rel: #1619

The actual memory allocation is performed by make_device_mdarray, so the corresponding memory allocation test should also be done using this function. However, the current code uses make_device_matrix for the test.

This PR fixes this inconsistency.

In the same source file, d_detour_count and d_num_no_detour_edges are allocated via make_device_mdarray, and d_input_graph is allocated through device_matrix_view_from_host (defined in cpp/src/neighbors/detail/cagra/utils.hpp), which internally calls make_device_mdarray.

@enp1s0 enp1s0 requested a review from a team as a code owner January 7, 2026 05:55
@enp1s0 enp1s0 self-assigned this Jan 7, 2026
@enp1s0 enp1s0 added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 7, 2026
@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jan 8, 2026

/merge

@rapids-bot rapids-bot Bot merged commit bae4cdb into rapidsai:main Jan 8, 2026
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants