Skip to content

FAISS patch for removed raft headers#1654

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:faiss-patch-raft-deprecated-apis
Dec 18, 2025
Merged

FAISS patch for removed raft headers#1654
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
aamijar:faiss-patch-raft-deprecated-apis

Conversation

@aamijar
Copy link
Copy Markdown
Member

@aamijar aamijar commented Dec 18, 2025

Removes unused raft headers from faiss which have now been removed from raft altogether.

xref: rapidsai/raft#2885

@aamijar aamijar requested a review from a team as a code owner December 18, 2025 02:25
@aamijar aamijar self-assigned this Dec 18, 2025
@aamijar aamijar added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 18, 2025
@aamijar aamijar moved this from Todo to In Progress in Unstructured Data Processing Dec 18, 2025
Copy link
Copy Markdown
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.

@KyleFromNVIDIA
Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot Bot merged commit a18d413 into rapidsai:main Dec 18, 2025
181 of 185 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Dec 18, 2025
@aamijar aamijar mentioned this pull request Jan 5, 2026
rapids-bot Bot pushed a commit that referenced this pull request Jan 6, 2026
Since this has been merged facebookresearch/faiss#4731, we no longer need the patch introduced in #1654

Authors:
  - Anupam (https://github.com/aamijar)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake faiss improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants