Add Helper to Create NumPy Files#1645
Merged
rapids-bot[bot] merged 8 commits intorapidsai:mainfrom Jan 15, 2026
Merged
Conversation
- Introduces `create_numpy_file` in the file_io.hpp header. - The function creates numpy files with pre-allocated space and writes the appropriate header based on the specified shape and data type. - Removes duplicated code. - Partly addresses rapidsai#1486.
10 tasks
cjnolet
added
improvement
tfeher
approved these changes
Jan 15, 2026
Contributor
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Jan 26, 2026
This PR introduces `create_numpy_file` in the file_io.hpp header. It creates NumPy files with pre-allocated space and writes the appropriate header based on the specified shape and data type. This removes duplicated code in CAGRA ACE in `cagra_build.cuh`. It addresses one follow-up item of rapidsai#1486. CC @tfeher Authors: - Julian Miller (https://github.com/julianmi) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#1645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
create_numpy_filein the file_io.hpp header. It creates NumPy files with pre-allocated space and writes the appropriate header based on the specified shape and data type. This removes duplicated code in CAGRA ACE incagra_build.cuh. It addresses one follow-up item of #1486.CC @tfeher