Skip to content

Remove Flaky Python ACE Example#1641

Merged
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom
julianmi:remove-ace-python-example
Dec 16, 2025
Merged

Remove Flaky Python ACE Example#1641
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom
julianmi:remove-ace-python-example

Conversation

@julianmi
Copy link
Copy Markdown
Contributor

The Python doc test shows sporadic segfaults in CI during cagra.build. This PR removes the problematic example. The CAGRA ACE build method is thoroughly tested in test_cagra_ace.py.

Additionally, the number of queries is used during cagra.search.

- The doctest shows sporadic segfaults in CI during cagra.build. This removes the problematic example.
- Use the number of queries during search.
@julianmi julianmi requested a review from a team as a code owner December 15, 2025 13:40
@tfeher tfeher added bug Something isn't working non-breaking Introduces a non-breaking change labels Dec 15, 2025
Comment thread python/cuvs/cuvs/neighbors/cagra/cagra.pyx
@julianmi julianmi changed the title Remove Flaky Python ACE example Remove Flaky Python ACE Example Dec 16, 2025
Copy link
Copy Markdown
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Created an issue for tracking the failing code example: #1647

Comment thread python/cuvs/cuvs/neighbors/cagra/cagra.pyx
@benfred
Copy link
Copy Markdown
Contributor

benfred commented Dec 16, 2025

/merge

@rapids-bot rapids-bot Bot merged commit d7a160c into rapidsai:main Dec 16, 2025
81 checks passed
@julianmi julianmi deleted the remove-ace-python-example branch April 27, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants