Skip to content

Optional seed spectral embedding#1639

Merged
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom
aamijar:optional-seed-spectral-embedding
Dec 17, 2025
Merged

Optional seed spectral embedding#1639
rapids-bot[bot] merged 4 commits intorapidsai:mainfrom
aamijar:optional-seed-spectral-embedding

Conversation

@aamijar
Copy link
Copy Markdown
Member

@aamijar aamijar commented Dec 13, 2025

Use std::optional for seed value to allow for null values to represent that user did not set a seed.

Depends on rapidsai/raft#2894

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Dec 13, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@aamijar aamijar self-assigned this Dec 13, 2025
@aamijar aamijar added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Dec 13, 2025
@aamijar aamijar marked this pull request as ready for review December 13, 2025 00:29
@aamijar aamijar requested a review from a team as a code owner December 13, 2025 00:29
@aamijar aamijar moved this from Todo to In Progress in Unstructured Data Processing Dec 13, 2025
@divyegala
Copy link
Copy Markdown
Member

/merge

@rapids-bot rapids-bot Bot merged commit 4eac302 into rapidsai:main Dec 17, 2025
178 of 180 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Dec 17, 2025
rapids-bot Bot pushed a commit to rapidsai/cuml that referenced this pull request Dec 18, 2025
Follow up to #7595. Depends on rapidsai/raft#2894 and rapidsai/cuvs#1639.

This PR sets the seed to null if the user passes no seed. Deterministic cusparse algorithm in raft is used if user passes in a seed.

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Jinsol Park (https://github.com/jinsolp)

URL: #7608
mani-builds pushed a commit to mani-builds/cuml that referenced this pull request Jan 11, 2026
Follow up to rapidsai#7595. Depends on rapidsai/raft#2894 and rapidsai/cuvs#1639.

This PR sets the seed to null if the user passes no seed. Deterministic cusparse algorithm in raft is used if user passes in a seed.

Authors:
  - Anupam (https://github.com/aamijar)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Jinsol Park (https://github.com/jinsolp)

URL: rapidsai#7608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants