Skip to content

[FEA] Enforce tighter link restrictions on libcuvs_c #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 6 commits into from
Dec 4, 2025
Merged

[FEA] Enforce tighter link restrictions on libcuvs_c #1614

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7392b11
Remove unneeded cmake variable being set
robertmaynard Dec 3, 2025
e57ebe3
Restrict libcuvs_c linking even more to ensure no dependencies leak
robertmaynard Dec 3, 2025
a4cd504
Apply suggestion from @KyleFromNVIDIA
robertmaynard Dec 3, 2025
3f953de
Fix style issues found by CI
robertmaynard Dec 3, 2025
e5c88ab
Make sure the cuvs C examples link against cudart
robertmaynard Dec 3, 2025
2bcdb91
Correct style issues found by CI
robertmaynard Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions c/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,10 @@ target_include_directories(

target_link_libraries(
cuvs_c
PUBLIC $<IF:$<BOOL:${CUVSC_STATIC_CUVS_LIBRARY}>,cuvs::cuvs_static,cuvs::cuvs>
PRIVATE raft::raft $<TARGET_NAME_IF_EXISTS:hnswlib::hnswlib>
PRIVATE # we don't want any dependencies exported
$<IF:$<BOOL:${CUVSC_STATIC_CUVS_LIBRARY}>,cuvs::cuvs_static,cuvs::cuvs> #
Comment thread
robertmaynard marked this conversation as resolved.
Outdated
$<COMPILE_ONLY:raft::raft> # enforce we shouldn't use raft symbols
$<TARGET_NAME_IF_EXISTS:hnswlib::hnswlib>
)

# ##################################################################################################
Expand Down
2 changes: 2 additions & 0 deletions c/tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ function(ConfigureTest)
add_executable(${TEST_NAME} ${_CUVS_TEST_PATH})
target_link_libraries(
${TEST_NAME} PRIVATE cuvs::c_api GTest::gtest GTest::gtest_main
$<IF:$<BOOL:${CUVSC_STATIC_CUVS_LIBRARY}>,$<COMPILE_ONLY:cuvs::cuvs_static>,cuvs::cuvs>
$<TARGET_NAME_IF_EXISTS:conda_env>
)
set_target_properties(
Expand Down Expand Up @@ -90,6 +91,7 @@ endif()

ConfigureTest(NAME cuvs_c_headers PATH core/headers.c)
ConfigureTest(NAME cuvs_c_test PATH core/c_api.c)
target_link_libraries(cuvs_c_test PRIVATE CUDA::cudart)
ConfigureTest(NAME cuvs_c_neighbors_test PATH neighbors/c_api.c)

# ##################################################################################################
Expand Down
1 change: 0 additions & 1 deletion ci/build_standalone_c.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ scl enable gcc-toolset-${TOOLSET_VERSION} -- \
cmake -S cpp -B cpp/build/ \
-DCMAKE_CUDA_HOST_COMPILER=/opt/rh/gcc-toolset-${TOOLSET_VERSION}/root/usr/bin/gcc \
-DCMAKE_CUDA_ARCHITECTURES=RAPIDS \
-DBUILD_SHARED_LIBS=OFF \
-DCUTLASS_ENABLE_TESTS=OFF \
-DDISABLE_OPENMP=OFF \
-DBUILD_TESTS=OFF \
Expand Down
Loading