Update FAISS patch for RMM memory resource header migration#1566
Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom Nov 19, 2025
Merged
Update FAISS patch for RMM memory resource header migration#1566rapids-bot[bot] merged 2 commits intorapidsai:mainfrom
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom
Conversation
divyegala
approved these changes
Nov 18, 2025
bdice
added
improvement
Contributor
Author
|
/merge |
tarang-jain
reviewed
Nov 19, 2025
| @@ -6,8 +6,8 @@ | |||
| "git_tag": "v1.12.0", | |||
Contributor
There was a problem hiding this comment.
Actually they just released v1.13.0. Can we tag that one?
Contributor
Author
There was a problem hiding this comment.
Discussed offline. We're going to merge this as-is to get main unblocked, then tackle 1.13 in a follow-up PR.
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
bdice
added a commit
to bdice/cuvs
that referenced
this pull request
Nov 22, 2025
Remove thrust include patches that are already in upstream FAISS 1.13.0. All other RMM API compatibility patches still apply cleanly. Related to rapidsai#1566
rapids-bot Bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
## Summary - Update FAISS dependency from 1.12.0 to 1.13.0 - Remove thrust include patches already present in FAISS 1.13.0 - All other RMM API compatibility patches still apply cleanly Verified that updated patches apply cleanly to FAISS v1.13.0. Follow-up to #1566. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #1585
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Dec 6, 2025
## Summary - Update FAISS dependency from 1.12.0 to 1.13.0 - Remove thrust include patches already present in FAISS 1.13.0 - All other RMM API compatibility patches still apply cleanly Verified that updated patches apply cleanly to FAISS v1.13.0. Follow-up to rapidsai#1566. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates FAISS patch for RMM memory resource header migration.
xref: rapidsai/rmm#2141