fixed bug with update-version.sh#1556
Merged
rockhowse merged 4 commits intorapidsai:release/25.12from Nov 18, 2025
Merged
Conversation
Contributor
Author
|
If we set the file back to what should exist in main: diff --git a/python/cuvs_bench/cuvs_bench/plot/__main__.py b/python/cuvs_bench/cuvs_bench/plot/__main__.py
index 15c98a44..683fe659 100644
--- a/python/cuvs_bench/cuvs_bench/plot/__main__.py
+++ b/python/cuvs_bench/cuvs_bench/plot/__main__.py
@@ -6,7 +6,7 @@
# 1: https://github.com/erikbern/ann-benchmarks/blob/release/main/plot.py
# 2: https://github.com/erikbern/ann-benchmarks/blob/release/main/ann_benchmarks/plotting/utils.py # noqa: E501
# 3: https://github.com/erikbern/ann-benchmarks/blob/release/main/ann_benchmarks/plotting/metrics.py # noqa: E501
-# License: https://github.com/rapidsai/cuvs/blob/release/25.12/thirdparty/LICENSES/LICENSE.ann-benchmark # noqa: E501
+# License: https://github.com/rapidsai/cuvs/blob/main/thirdparty/LICENSES/LICENSE.ann-benchmark # noqa: E501And re-run the >./ci/release/update-version.sh --run-context=release 25.12.00
Using run-context from CLI: release
Preparing release branch update 25.12.00a => 25.12.00 (targeting release/25.12 branch)
> git diff
<no differences> |
bdice
reviewed
Nov 18, 2025
bdice
approved these changes
Nov 18, 2025
…in-functions-in-python
trxcllnt
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a bug in the
update-versions.shscript to tighten the regular expression to limit themain->release/YY.MMpattern so it's limited to only thecuvsURL in the SPDX header section.non-cuvsSPDX headers are modifiedpython/cuvs_bench/cuvs_bench/plot/__main__.pyfile should no longer be modifiedIn theory this should forward merge and NOT be reverted as it:
update-versions.shscript to have limitedregexnon-cuvsurls to usemaininstead ofrelease/25.12<-- will be a no-op inmain?