Skip to content

fixed bug with update-version.sh#1556

Merged
rockhowse merged 4 commits intorapidsai:release/25.12from
rockhowse:fix-update-version-to-not-change-main-functions-in-python
Nov 18, 2025
Merged

fixed bug with update-version.sh#1556
rockhowse merged 4 commits intorapidsai:release/25.12from
rockhowse:fix-update-version-to-not-change-main-functions-in-python

Conversation

@rockhowse
Copy link
Copy Markdown
Contributor

This addresses a bug in the update-versions.sh script to tighten the regular expression to limit the main -> release/YY.MM pattern so it's limited to only the cuvs URL in the SPDX header section.

  • no non-cuvs SPDX headers are modified
  • all other references to main in the python/cuvs_bench/cuvs_bench/plot/__main__.py file should no longer be modified

In theory this should forward merge and NOT be reverted as it:

  • fixes the update-versions.sh script to have limited regex
  • reverts the non-cuvs urls to use main instead of release/25.12 <-- will be a no-op in main?

@rockhowse rockhowse requested review from a team as code owners November 18, 2025 03:31
@rockhowse rockhowse requested a review from AyodeAwe November 18, 2025 03:31
@rockhowse rockhowse added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 18, 2025
@rockhowse rockhowse self-assigned this Nov 18, 2025
@rockhowse
Copy link
Copy Markdown
Contributor Author

If we set the file back to what should exist in main:

diff --git a/python/cuvs_bench/cuvs_bench/plot/__main__.py b/python/cuvs_bench/cuvs_bench/plot/__main__.py
index 15c98a44..683fe659 100644
--- a/python/cuvs_bench/cuvs_bench/plot/__main__.py
+++ b/python/cuvs_bench/cuvs_bench/plot/__main__.py
@@ -6,7 +6,7 @@
 # 1: https://github.com/erikbern/ann-benchmarks/blob/release/main/plot.py
 # 2: https://github.com/erikbern/ann-benchmarks/blob/release/main/ann_benchmarks/plotting/utils.py  # noqa: E501
 # 3: https://github.com/erikbern/ann-benchmarks/blob/release/main/ann_benchmarks/plotting/metrics.py  # noqa: E501
-# License: https://github.com/rapidsai/cuvs/blob/release/25.12/thirdparty/LICENSES/LICENSE.ann-benchmark # noqa: E501
+# License: https://github.com/rapidsai/cuvs/blob/main/thirdparty/LICENSES/LICENSE.ann-benchmark # noqa: E501

And re-run the update-version.sh in release mode with version 25.12, the only line that gets updated to release/25.12 is the expected rapidsai/cuvs line in the SPDX header section

>./ci/release/update-version.sh --run-context=release 25.12.00 
Using run-context from CLI: release
Preparing release branch update 25.12.00a => 25.12.00 (targeting release/25.12 branch)

> git diff 
<no differences> 

Comment thread python/cuvs_bench/cuvs_bench/plot/__main__.py Outdated
@rockhowse rockhowse merged commit 2a91287 into rapidsai:release/25.12 Nov 18, 2025
22 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants