Skip to content

[Java] Fix format with spotless#1539

Merged
rapids-bot[bot] merged 5 commits intorapidsai:release/25.12from
ldematte:java/fix-format-spotless
Nov 17, 2025
Merged

[Java] Fix format with spotless#1539
rapids-bot[bot] merged 5 commits intorapidsai:release/25.12from
ldematte:java/fix-format-spotless

Conversation

@ldematte
Copy link
Copy Markdown
Contributor

Changes introduced with #1404 were not formatted correctly
Running spotless (via build.sh) fixed the formatting.

CC @mythrocks @cjnolet

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Nov 14, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mythrocks mythrocks changed the title [REVIEW][Java] Fix format with spotless [Java] Fix format with spotless Nov 14, 2025
Copy link
Copy Markdown
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the PR's CI didn't catch that. Thanks for fixing this, @ldematte.

@mythrocks mythrocks moved this from Todo to In Progress in Unstructured Data Processing Nov 14, 2025
@mythrocks mythrocks added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 14, 2025
@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test f662e1e

@mythrocks
Copy link
Copy Markdown
Contributor

/merge

@mythrocks
Copy link
Copy Markdown
Contributor

There seems to be a transient failure in CI: https://github.com/rapidsai/cuvs/actions/runs/19369951714/job/55447835806?pr=1539

[----------] Global test environment tear-down
[==========] 256 tests from 4 test suites ran. (55364 ms total)
[  PASSED  ] 255 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] AnnHNSWTest/AnnHNSW_H.AnnHNSW/1, where GetParam() = dataset shape=1000x5, graph_degree=32, metric=distance::InnerProduct, ef=250
...
 1 FAILED TEST
CMake Error at run_gpu_test.cmake:26 (execute_process):
  execute_process failed command indexes:

    1: "Child return code: 1"
...
97% tests passed, 1 tests failed out of 30

Total Test time (real) = 5611.04 sec

The following tests FAILED:
	 25 - NEIGHBORS_HNSW_TEST (Failed)

I'll see if this has been fixed upstream, and raise a bug if it recurs.

@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test 959c91f

@cjnolet cjnolet changed the base branch from main to release/25.12 November 17, 2025 18:20
@cjnolet cjnolet requested review from a team as code owners November 17, 2025 18:20
@cjnolet cjnolet requested review from AyodeAwe and removed request for a team November 17, 2025 18:20
@rapids-bot rapids-bot Bot merged commit 80d4d72 into rapidsai:release/25.12 Nov 17, 2025
82 of 88 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Nov 17, 2025
@ldematte ldematte deleted the java/fix-format-spotless branch November 18, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants