Skip to content

Set memory pool from Python multi-GPU resource#1530

Merged
rapids-bot[bot] merged 7 commits intorapidsai:release/25.12from
viclafargue:set-mem-pool-with-multi-gpu-res
Nov 17, 2025
Merged

Set memory pool from Python multi-GPU resource#1530
rapids-bot[bot] merged 7 commits intorapidsai:release/25.12from
viclafargue:set-mem-pool-with-multi-gpu-res

Conversation

@viclafargue
Copy link
Copy Markdown
Contributor

@viclafargue viclafargue commented Nov 11, 2025

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner November 11, 2025 16:20
@viclafargue viclafargue changed the title Set memory pool from multi-GPU resource Set memory pool from Python multi-GPU resource Nov 11, 2025
@viclafargue viclafargue added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 11, 2025
jinsolp
jinsolp approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viclafargue LGTM 👍

@viclafargue viclafargue requested a review from benfred November 13, 2025 13:08
benfred
benfred approved these changes Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@benfred
Copy link
Copy Markdown
Contributor

benfred commented Nov 13, 2025

/merge

@cjnolet cjnolet changed the base branch from main to release/25.12 November 17, 2025 18:17
@cjnolet cjnolet requested review from a team as code owners November 17, 2025 18:17
@cjnolet cjnolet requested review from msarahan and removed request for a team November 17, 2025 18:17
@rapids-bot rapids-bot Bot merged commit 142110b into rapidsai:release/25.12 Nov 17, 2025
13 checks passed
@AyodeAwe
Copy link
Copy Markdown
Contributor

AyodeAwe commented Nov 17, 2025 •
edited
Loading

@cjnolet We noticed that this PR merged changes from main into release/25.12, and since main is now targeting 26.02 (after burndown), we wanted to confirm your intent.

Did you assume that all the changes currently in main should be part of the 25.12 release (aside from the version numbers)?

The issue is that when changes from main (which is now on 26.02) get merged into release/25.12, it brings over version numbers and potentially other changes that are meant for the next release cycle. We need to ensure the release/25.12 branch only contains 25.12-appropriate content and version numbers.

We're planning to run update-version.sh 25.12.00 on the release/25.12 branch to correct the version numbers back to 25.12, but wanted to make sure we're aligned on whether the other changes that came from main (namely: this commit) are appropriate for the 25.12 release or if they should be reverted.

Thanks!

@AyodeAwe AyodeAwe mentioned this pull request Nov 17, 2025
Merged
AyodeAwe added a commit that referenced this pull request Nov 17, 2025
@AyodeAwe
Fix version numbers in release/25.12 branch (#1551)
81783ea 
### Problem
PR #1530 merged changes from `main` into `release/25.12` after burndown,
which brought over version numbers targeting 26.02 instead of 25.12.

### Solution
This PR corrects the version numbers by running `update-version.sh
25.12.00 --run-context=release` to ensure the `release/25.12` branch has
the appropriate 25.12.00 version numbers.

### Background
- After burndown, `main` branch targets 26.02
- PR #1530 was retargeted from `main` to `release/25.12`, after updating
the PR with changes from `main`, inadvertently bringing `26.02` version
numbers
- This fix ensures release branch integrity by correcting version
metadata

### Changes
- Updated version numbers across all relevant files to 25.12.00
- No functional code changes
@AyodeAwe
Copy link
Copy Markdown
Contributor

AyodeAwe commented Nov 17, 2025

Version numbers have been reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinsolp jinsolp jinsolp approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

+1 more reviewer

@benfred benfred benfred approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@achirkin achirkin

@jinsolp jinsolp

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Unstructured Data Processing
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@viclafargue @benfred @AyodeAwe @jinsolp @achirkin @GPUtester @cjnolet