Extend CI to build and test x86 libcuvs_c tarballs#1524
Merged
rapids-bot[bot] merged 7 commits intorapidsai:mainfrom Nov 14, 2025
Merged
Extend CI to build and test x86 libcuvs_c tarballs#1524rapids-bot[bot] merged 7 commits intorapidsai:mainfrom
rapids-bot[bot] merged 7 commits intorapidsai:mainfrom
Conversation
robertmaynard
force-pushed
the
fea/cuvs_c_ci
branch
from
b4d014c to
96ee53a
Compare
AyodeAwe
approved these changes
Nov 12, 2025
bdice
reviewed
Nov 13, 2025
| with: | ||
| build_type: ${{ inputs.build_type || 'branch' }} | ||
| branch: ${{ inputs.branch }} | ||
| arch: "amd64" |
Contributor
There was a problem hiding this comment.
Are we only supporting amd64 with the C library?
Contributor
Author
There was a problem hiding this comment.
I have on my todo to extend the matrix to arm + x86 but that isn't a hard requirement for 25.12.
If you know how to easily extend the matrix in a custom job I would happily integrate it into this PR.
When I was looking at other yaml files it seemed complicated ( dumping to file for some reason )
Contributor
There was a problem hiding this comment.
Let's defer this until later. You can just add a matrix entry here like already exists for the CUDA keys and then use ${{ matrix.arch }} in the arch: value but let's get one arch done before we expand.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Nov 13, 2025
Contributor
Author
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Nov 16, 2025
Adds new `rocky8-clib-standalone-build` and `rocky8-clib-tests` PR jobs that validate that the C api binaries can be built and run all C tests correctly. Also adds a new nightly build job that produces the C api binaries. Authors: - Robert Maynard (https://github.com/robertmaynard) - Ben Frederickson (https://github.com/benfred) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Bradley Dice (https://github.com/bdice) URL: rapidsai#1524
rapids-bot Bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
We can't require users of prebuilt versions of libcuvs_c to install rapids-logger headers. The current strategy in #1524 is to build rapids-logger statically which makes it even more non-obvious to users why they need rapids-logger headers Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Ben Frederickson (https://github.com/benfred) - Vyas Ramasubramani (https://github.com/vyasr) - Divye Gala (https://github.com/divyegala) URL: #1527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new
rocky8-clib-standalone-buildandrocky8-clib-testsPR jobs that validate that the C api binaries can be built and run all C tests correctly.Also adds a new nightly build job that produces the C api binaries.