Skip to content

Single Linkage to Use all_neighbors API to build the KNN graph#1507

Merged
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom
tarang-jain:single-linkage-bf
Nov 7, 2025
Merged

Single Linkage to Use all_neighbors API to build the KNN graph#1507
rapids-bot[bot] merged 9 commits intorapidsai:mainfrom
tarang-jain:single-linkage-bf

Conversation

@tarang-jain
Copy link
Copy Markdown
Contributor

@tarang-jain tarang-jain commented Nov 6, 2025

Closes #1515

The brute force KNN graph was being built from brute force functions in the detail namespace, which can be replaced by the all_neighbors API. This PR should save binary size, which I'll post after the CI run.

[Update]: Binary Size Reduction:
CUDA 13.0: 15 MB -> 8.415 MB
CUDA 12.9: 28 MB -> 12.684 MB

@tarang-jain tarang-jain self-assigned this Nov 6, 2025
@tarang-jain tarang-jain added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Nov 6, 2025
Copy link
Copy Markdown
Member

@aamijar aamijar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

Comment thread cpp/src/neighbors/detail/knn_graph.cuh Outdated
@tarang-jain
Copy link
Copy Markdown
Contributor Author

/ok to test b21ac98

@jinsolp jinsolp self-requested a review November 7, 2025 00:47
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tarang-jain
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 5254fa7 into rapidsai:main Nov 7, 2025
161 of 164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use all_neighbors API in SLHC

4 participants