Skip to content

Fix binary quantizer host transform bounds and stream order#1473

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
achirkin:fix-host-binary-quantizer-not-initializing-padded-elements
Oct 29, 2025
Merged

Fix binary quantizer host transform bounds and stream order#1473
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
achirkin:fix-host-binary-quantizer-not-initializing-padded-elements

Conversation

@achirkin
Copy link
Copy Markdown
Contributor

Fix two issues with the binary quantizer's host transform:

  1. Synchronize the stream after async GPU operations and before a host-only omp loop;
  2. Fill the bytes between minimul_out_dim and out_dim with zeroes to match device transform behavior.

This PR is a prerequisite to merging rapidsai/raft#2835 (otherwise the tests fail due to host mdarray not initializing with zeroes anymore).

@achirkin achirkin requested a review from a team as a code owner October 29, 2025 07:18
@achirkin achirkin self-assigned this Oct 29, 2025
@achirkin achirkin added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 29, 2025
@achirkin achirkin moved this from Todo to In Progress in Unstructured Data Processing Oct 29, 2025
@enp1s0 enp1s0 self-requested a review October 29, 2025 08:06
Copy link
Copy Markdown
Member

@enp1s0 enp1s0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @achirkin for the PR. It looks good to me.

Copy link
Copy Markdown
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achirkin
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 424a3e9 into rapidsai:main Oct 29, 2025
242 of 246 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unstructured Data Processing Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants