[BUG] Check if dynamic batching conf is null#1459
Merged
rapids-bot[bot] merged 12 commits intorapidsai:mainfrom Oct 29, 2025
Merged
[BUG] Check if dynamic batching conf is null#1459rapids-bot[bot] merged 12 commits intorapidsai:mainfrom
rapids-bot[bot] merged 12 commits intorapidsai:mainfrom
Conversation
tarang-jain
added
bug
achirkin
approved these changes
Oct 25, 2025
Contributor
achirkin
left a comment
achirkin
left a comment
There was a problem hiding this comment.
Hi @tarang-jain thanks for the fix! I've seen the offline discussion of the issue, but could you please add an explanation of the issue this PR solves in the PR description? This helps a lot when searching for changes in the commit history.
Contributor
Author
|
@achirkin done! I updated the PR description. |
benfred
approved these changes
Oct 27, 2025
Contributor
Author
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds pytests for
cuvs_ivf_pqalgorithm in cuvs-bench.Bug explanation: CAGRA with IVF-PQ as the
graph_build_algogives an error when dynamic batching params are not set for IVF-PQ:ERROR OCCURRED: '[json.exception.type_error.306] cannot use value() with null'Ths PR fixes that and also adds pytests for
cuvs_ivf_pqalgorithm in cuvs-bench.