Use rapids-build-backend#145
Merged
rapids-bot[bot] merged 14 commits intorapidsai:branch-24.08from May 31, 2024
Merged
Conversation
KyleFromNVIDIA
added
improvement
AyodeAwe
approved these changes
May 28, 2024
dantegd
approved these changes
May 28, 2024
jameslamb
approved these changes
May 29, 2024
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
I left 2 very very very minor comments... do whatever you want with them, and I don't need to review again when they're addressed.
bdice
approved these changes
May 30, 2024
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
A couple small comments, but otherwise looks good! Resolve those as you see fit.
Member
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
…wup (#185) Contributes to rapidsai/build-planning#31 Contributes to rapidsai/dependency-file-generator#89 Since #145 was merged, we've made some small adjustments to the approach for `rapids-build-backend`. This catches `cuvs` up with those changes: * consolidates version-handling in `ci/` scripts * uses `--file-key` instead of `--file_key` in `rapids-dependency-file-generator` calls Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #185
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#31.