Fix C/Python serialization for FP16. Add python tests#1429
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from Oct 15, 2025
Merged
Fix C/Python serialization for FP16. Add python tests#1429rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from
Conversation
Signed-off-by: Mickael Ide <mide@nvidia.com>
lowener
added
bug
benfred
approved these changes
Oct 14, 2025
Contributor
benfred
left a comment
benfred
left a comment
There was a problem hiding this comment.
good catch - we should definitely be using 'e' for the char code for float16 to align with numpy/raft https://numpy.org/doc/stable/reference/arrays.scalars.html#numpy.half
Thanks for updating the unittests to test this out too!
Contributor
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
Fix rapidsai#1419 by aligning with the format present in raft: https://github.com/rapidsai/raft/blob/branch-25.12/cpp/include/raft/core/detail/mdspan_numpy_serializer.hpp#L129-134 Authors: - Micka (https://github.com/lowener) Approvers: - Ben Frederickson (https://github.com/benfred) URL: rapidsai#1429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1419 by aligning with the format present in raft: https://github.com/rapidsai/raft/blob/branch-25.12/cpp/include/raft/core/detail/mdspan_numpy_serializer.hpp#L129-134