[Review][Java] Refactor: extract interface from CuVSMatrixBaseImpl#1361
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from Sep 24, 2025
Merged
Conversation
…all internal CuVSMatrix types
ldematte
changed the title
ldematte
commented
Sep 23, 2025
| return new CuVSDeviceMatrixDelegate(this); | ||
| } | ||
|
|
||
| class CuVSDeviceMatrixDelegate implements CuVSDeviceMatrix { |
Contributor
Author
There was a problem hiding this comment.
These got moved to internal implementation classes, for better encapsulation and to use the internal interface type.
ldematte
commented
Sep 23, 2025
| return deviceMatrix; | ||
| } | ||
|
|
||
| class CuVSHostMatrixDelegate implements CuVSHostMatrix { |
cjnolet
added
improvement
Contributor
|
/ok to test 936c6f4 |
benfred
approved these changes
Sep 24, 2025
Contributor
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
…apidsai#1361) This PR extract an internal interface that is used as a base to implement all internal CuVSMatrix types; the interface introduces commonly used field accessors like `memorySegment()` and `toTensor()` that we do not want/could not appear on the public interface (e.g. because they expose or require Panama types or internal types). The new interface is implemented by all concrete matrix types, closing a gap that we had in rapidsai#1328 (which I realized while working on separate PRs like rapidsai#1283) Follow-up of rapidsai#1328 Authors: - Lorenzo Dematté (https://github.com/ldematte) Approvers: - Ben Frederickson (https://github.com/benfred) URL: rapidsai#1361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extract an internal interface that is used as a base to implement all internal CuVSMatrix types; the interface introduces commonly used field accessors like
memorySegment()andtoTensor()that we do not want/could not appear on the public interface (e.g. because they expose or require Panama types or internal types).The new interface is implemented by all concrete matrix types, closing a gap that we had in #1328 (which I realized while working on separate PRs like #1283)
Follow-up of #1328