Refactor libcuvs_c header and source locations#1357
Conversation
|
By moving this into a separate header it will reduce the complexity of reviewing #1348 |
|
Rather than put in the c headers in Right now the user has to add an extra |
This opens us to incorrect installs of libcuvs or libcuvs_c since when we install we flatten everything to the same install location of The current model of the source tree layout is that the |
|
I am happy to try moving everything over to |
6877a1b to
782af85
Compare
782af85 to
03c0a2c
Compare
805a825 to
80df255
Compare
|
/ok to test 8afc1c1 |
benfred
left a comment
There was a problem hiding this comment.
thanks for these changes! I think this looks great, and I like how clean the separation is between the c and c++ code with this change -
|
/merge |
895515c
into
rapidsai:branch-25.12
In support of building a stable C interface for libcuvs I have moved all `C` code into a separate directory for both the headers and sources. This will make it easier to install just 'C' language headers, make it easier to apply code rules for C headers, and in the future add more CI checks for our C API. Authors: - Robert Maynard (https://github.com/robertmaynard) - MithunR (https://github.com/mythrocks) - Ben Frederickson (https://github.com/benfred) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Ben Frederickson (https://github.com/benfred) URL: rapidsai#1357
In support of building a stable C interface for libcuvs I have moved all
Ccode into a separate directory for both the headers and sources. This will make it easier to install just 'C' language headers, make it easier to apply code rules for C headers, and in the future add more CI checks for our C API.