Allow compilation when OpenMP is disabled#1346
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.12from Oct 1, 2025
Merged
Conversation
Since we compile CUVS with warnings as errors, we need to disable the unknown pragma warning generated by our OpenMP pragmas so we can still compile.
tfeher
approved these changes
Sep 22, 2025
Contributor
tfeher
left a comment
tfeher
left a comment
There was a problem hiding this comment.
Thanks @robertmaynard, LGTM.
Contributor
Author
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
rmaschal
pushed a commit
to rmaschal/cuvs
that referenced
this pull request
Oct 6, 2025
Since we compile CUVS with warnings as errors, we need to disable the unknown pragma warning generated by our OpenMP pragmas so we can still compile. Authors: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#1346
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
Since we compile CUVS with warnings as errors, we need to disable the unknown pragma warning generated by our OpenMP pragmas so we can still compile. Authors: - Robert Maynard (https://github.com/robertmaynard) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#1346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we compile CUVS with warnings as errors, we need to disable the unknown pragma warning generated by our OpenMP pragmas so we can still compile.