Removing libraft.so from libcuvs dependencies#132
Merged
Conversation
Co-authored-by: Corey J. Nolet <[email protected]>
cjnolet
added
improvement
divyegala
reviewed
May 17, 2024
divyegala
approved these changes
May 17, 2024
Member
Author
|
/merge |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, libraft.so is still a dependency of pylibraft and so it's needed in order to use pylibraft. We'll work on that during the 24.08 release cycle. For now, libraft.so is no longer a required dependency to build
libcuvsor any of its wrappers.