Fix pq_compressed file created by SSD Vamana build#1313
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.10from Sep 16, 2025
Merged
Fix pq_compressed file created by SSD Vamana build#1313rapids-bot[bot] merged 4 commits intorapidsai:branch-25.10from
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.10from
Conversation
tarang-jain
reviewed
Sep 5, 2025
Contributor
|
There are some merge conflicts. Other than that this PR looks good! |
cjnolet
approved these changes
Sep 15, 2025
tarang-jain
approved these changes
Sep 15, 2025
Member
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with pq_compressed files being incorrect when GPU vamana build was being provided opq codebooks as an input to the build. Bug was caused by vq_centers not being set to 0s, despite OPQ compression not using vq centers, and only using pq_centers during quantized vector encoding.
Also cleaned up vamana_example file to support other datatypes and function correctly when building the DiskANN index without quantization.