Fix redundant memset#1305
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.10from Sep 2, 2025
Merged
Conversation
aamijar
added
non-breaking
Contributor
|
/ok to test 2102b07 |
Contributor
Author
|
The failure does not seem related to this PR. Should we rerun the tests? |
Contributor
|
/merge |
rapids-bot
Bot
merged commit 3ca1ed9
into
rapidsai:branch-25.10
164 of 166 checks passed
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace is already being reset in the calling function
fusedDistanceNNImpl, see https://github.com/rapidsai/cuvs/blob/branch-25.10/cpp/src/distance/detail/fused_distance_nn.cuh#L73Therefore removing the memset in
fusedL2NNImpl