Added UINT to assert in toArray#1269
Conversation
|
@narangvivek10 please add more details on how you encountered this issue. Also, any ideas how we can test for that scenario? |
|
It would be good to raise a bug indicating the error that @narangvivek10 ran into on this front, and add a "fixes XXXX" in the description of this PR. Maybe include a snippet of how the bug manifests in the PR description. |
ldematte
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding this!
We are missing tests where the input data is int and the datatype is UINT. Those can be added to Maybe related/more importantly, we are missing a lot of tests on index operations (build, search, etc.): those are only with a host matrix/heap input (no device matrix) and only for float (no int or byte). |
|
But wait, I believe your branch is just out of date -- I have fixed this already as part of #1232 EDIT: yep, very unfortunate timing: you raised this PR on August 21, and my PR got merged on August 22. |
|
@punAhuja: Could you please check if the latest commits already address what this PR attempts to solve? |
Yes, the latest commits already address what this PR attempts to solve. Will close this PR. |
Added assert for UINT datatype.
As per issue encountered and debugged by @narangvivek10 while working on Lucene HNSW serialization